[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8564: Disallow drop of task manager widgets outside of plasmoid when locked
From:       Emirald Mateli <noreply () phabricator ! kde ! org>
Date:       2017-10-31 8:58:50
Message-ID: differential-rev-PHID-DREV-7ey2r42oi7qhq46hqgtb-req () phabricator ! kde ! org
[Download RAW message or body]

emateli created this revision.
emateli added a reviewer: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  This patch disallows dropping task manager items outside of the plasmoid when \
widgets are locked.  As a user whose primary device is a laptop (with a touch screen \
at that) I find myself involuntarily dragging task manager icons to other \
applications, such as a maximized browser window or a code editor. This leads to \
`.desktop` files being dropped in various applications, which I can assume is not \
something one wants to do very often(if at all?).  
  This patch disables this functionality when widgets are locked. When they are \
unlocked the behaviour stays the same(so icons can be dragged into the desktop and so \
on).  
  This affects "Task Manager" and "Icons-Only Task manager" plasmoids.

TEST PLAN
  Have a panel with task manager
  
  - Lock widgets
  - Try to drop icons outside of panel

REPOSITORY
  R119 Plasma Desktop

BRANCH
  disable-drop

REVISION DETAIL
  https://phabricator.kde.org/D8564

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/plugin/draghelper.cpp

To: emateli, plasma-devel
Cc: ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart


[Attachment #3 (unknown)]

<table><tr><td style="">emateli created this revision.<br />emateli added a reviewer: \
plasma-devel.<br />Restricted Application added a project: Plasma. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8564" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>This patch disallows dropping task manager items outside of \
the plasmoid when widgets are locked.<br /> As a user whose primary device is a \
laptop (with a touch screen at that) I find myself involuntarily dragging task \
manager icons to other applications, such as a maximized browser window or a code \
editor. This leads to <tt style="background: #ebebeb; font-size: 13px;">.desktop</tt> \
files being dropped in various applications, which I can assume is not something one \
wants to do very often(if at all?).</p>

<p>This patch disables this functionality when widgets are locked. When they are \
unlocked the behaviour stays the same(so icons can be dragged into the desktop and so \
on).</p>

<p>This affects &quot;Task Manager&quot; and &quot;Icons-Only Task manager&quot; \
plasmoids.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Have a panel \
with task manager</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Lock widgets</li>
<li class="remarkup-list-item">Try to drop icons outside of panel</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>disable-drop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8564" \
rel="noreferrer">https://phabricator.kde.org/D8564</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/taskmanager/package/contents/ui/Task.qml<br /> \
applets/taskmanager/plugin/draghelper.cpp</div></div></div><br /><div><strong>To: \
</strong>emateli, plasma-devel<br /><strong>Cc: </strong>ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]