[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8563: Folder View icons properties: Improve visual layout
From:       Jonathan Marten <noreply () phabricator ! kde ! org>
Date:       2017-10-31 8:07:45
Message-ID: differential-rev-PHID-DREV-hvrcnvj4mzhfl6uiqv7g-req () phabricator ! kde ! org
[Download RAW message or body]

marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change is similar to https://phabricator.kde.org/D8424, for the "Icons" tab of \
the dialogue.  In the current layout:  
  F5459638: folderview-properties-icons_BEFORE.png \
<https://phabricator.kde.org/F5459638>  
  the controls are all of varying sizes and are not aligned, and the group titles are \
indented so far that they are not immediately recognisable as such.  
  The revised layout:
  
  F5459640: folderview-properties-icons_AFTER.png \
<https://phabricator.kde.org/F5459640>  
  uses a single grid layout to enforce the sizes and alignment of the GUI controls.
  
  Note that the screen shots above have had the QML tweaked to show all of the \
controls, in order to demonstrate the entire layout.  In practice (and in the diff \
here of course) not all of the controls are shown depending on the containment type \
of the folder view.

TEST PLAN
  Built plasma-desktop with this change. Checked appearance and operation of the \
configuration dialogue both as a desktop containment and as a standalone plasmoid.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8563

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">marten created this revision.<br />marten added a reviewer: \
Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8563" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
change is similar to <a href="https://phabricator.kde.org/D8424" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" rel="noreferrer">D8424</a>, \
for the &quot;Icons&quot; tab of the dialogue.  In the current layout:</p>

<p><a href="https://phabricator.kde.org/F5459638" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F5459638: \
folderview-properties-icons_BEFORE.png</a></p>

<p>the controls are all of varying sizes and are not aligned, and the group titles \
are indented so far that they are not immediately recognisable as such.</p>

<p>The revised layout:</p>

<p><a href="https://phabricator.kde.org/F5459640" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F5459640: \
folderview-properties-icons_AFTER.png</a></p>

<p>uses a single grid layout to enforce the sizes and alignment of the GUI \
controls.</p>

<p>Note that the screen shots above have had the QML tweaked to show all of the \
controls, in order to demonstrate the entire layout.  In practice (and in the diff \
here of course) not all of the controls are shown depending on the containment type \
of the folder view.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Built \
plasma-desktop with this change. Checked appearance and operation of the \
configuration dialogue both as a desktop containment and as a standalone \
plasmoid.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8563" \
rel="noreferrer">https://phabricator.kde.org/D8563</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>containments/desktop/package/contents/ui/ConfigIcons.qml</div></div></div><br \
/><div><strong>To: </strong>marten, Plasma<br /><strong>Cc: </strong>plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]