From kde-panel-devel  Mon Oct 30 14:40:48 2017
From: Xuetian Weng <noreply () phabricator ! kde ! org>
Date: Mon, 30 Oct 2017 14:40:48 +0000
To: kde-panel-devel
Subject: D8529: Plasma change icons should exit after its work finished.
Message-Id: <20171030144048.45849.701B27494C7CBFEF () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=150937445926723
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--5dae74322c934dfd823f8d2f2edcaa32"

--5dae74322c934dfd823f8d2f2edcaa32
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

xuetianweng added a comment.


  @mart I understand what you want to say, but for this specific case:
  
  https://lxr.kde.org/source/frameworks/kio/src/widgets/kbuildsycocaprogressdialog.cpp#0037
  
  rebuildKSycoca invokes dialog.exec() so it returns after the rebuild is done.
  
  And thus there's no signal that can be used for this function.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8529

To: xuetianweng, apol, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

--5dae74322c934dfd823f8d2f2edcaa32
Content-Transfer-Encoding: 7bit
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style="">xuetianweng added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8529" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p><a href="https://phabricator.kde.org/p/mart/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@mart</a> I understand what you want to say, but for this specific case:</p>

<p><a href="https://lxr.kde.org/source/frameworks/kio/src/widgets/kbuildsycocaprogressdialog.cpp#0037" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/frameworks/kio/src/widgets/kbuildsycocaprogressdialog.cpp#0037</a></p>

<p>rebuildKSycoca invokes dialog.exec() so it returns after the rebuild is done.</p>

<p>And thus there&#039;s no signal that can be used for this function.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8529" rel="noreferrer">https://phabricator.kde.org/D8529</a></div></div><br /><div><strong>To: </strong>xuetianweng, apol, mart<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
--5dae74322c934dfd823f8d2f2edcaa32--