[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8534: DictEngine: set a scheme for the URLs, otherwise webengine won't handle them
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2017-10-28 8:42:31
Message-ID: differential-rev-PHID-DREV-eqgkq775upjipubvmcop-req () phabricator ! kde ! org
[Download RAW message or body]

dfaure created this revision.
dfaure added reviewers: Plasma, davidedmundson, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  AFAICS the only other user for the engine (other than the applet I'm
  porting) is the runner for KRunner, where links don't work anyway.
  
  Port to QRegularExpression while at it.

TEST PLAN
  Tested with the upcoming dict applet.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8534

AFFECTED FILES
  dataengines/dict/dictengine.cpp

To: dfaure, #plasma, davidedmundson, broulik
Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">dfaure created this revision.<br />dfaure added reviewers: \
Plasma, davidedmundson, broulik.<br />Restricted Application added a project: \
Plasma.<br />Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8534" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>AFAICS the only other user for the engine (other than the \
applet I&#039;m<br /> porting) is the runner for KRunner, where links don&#039;t work \
anyway.</p>

<p>Port to QRegularExpression while at it.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Tested with the upcoming dict applet.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>Plasma/5.11</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8534" \
rel="noreferrer">https://phabricator.kde.org/D8534</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>dataengines/dict/dictengine.cpp</div></div></div><br \
/><div><strong>To: </strong>dfaure, Plasma, davidedmundson, broulik<br /><strong>Cc: \
</strong>plasma-devel, Plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]