[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8526: add a background in ScrollView
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2017-10-27 15:35:15
Message-ID: 20171027153515.47705.8856047AB3F21ACB () phabricator ! kde ! org
[Download RAW message or body]
davidedmundson added a comment.
In general ++. The frame is useful for keyboard focus indication if nothing else.
INLINE COMMENTS
> ScrollView.qml:47
> + visible: false
> + elementType: "edit"
> +
As in a textedit?
The QQC1 code used "frame" which is semantically more appropriate.
Did you do this to get the white background?
In QWidgets a scrollarea is transparent, and an itemview is white.
I think we might need some way (extra Kirigami class ?) to have both.
I suggest holding out on merging till we do a bit more KCM porting and figure that \
out.
> ScrollView.qml:79
> }
> - //TODO: use kirigami for this more granular control
> + //TODO: use kirigami for this more granular controlRoot
> /* var sampleItem = flickableItem.itemAt ? \
> flickableItem.itemAt(0,flickableItem.contentY) : null;
> D
maybe don't find and replace this
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D8526
To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8526" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>In general ++. The frame is useful for \
keyboard focus indication if nothing else.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8526#inline-36802" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ScrollView.qml:47</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">visible:</span> <span style="color: #000a65">false</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">elementType:</span> <span style="color: \
#766510">"edit"</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As \
in a textedit?</p>
<p style="padding: 0; margin: 8px;">The QQC1 code used "frame" which is \
semantically more appropriate.</p>
<p style="padding: 0; margin: 8px;">Did you do this to get the white background?</p>
<p style="padding: 0; margin: 8px;">In QWidgets a scrollarea is transparent, and an \
itemview is white.</p>
<p style="padding: 0; margin: 8px;">I think we might need some way (extra Kirigami \
class ?) to have both.</p>
<p style="padding: 0; margin: 8px;">I suggest holding out on merging till we do a bit \
more KCM porting and figure that out.</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8526#inline-36801" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">ScrollView.qml:79</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> \
<span class="p">}</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);"> <span style="color: #74777d">//TODO: use \
kirigami for this more granular control</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #74777d">//TODO: use kirigami for this more granular control<span \
class="bright">Root</span></span> </div><div style="padding: 0 8px; margin: 0 4px; "> \
<span style="color: #74777d">/* var sampleItem = flickableItem.itemAt ? \
flickableItem.itemAt(0,flickableItem.contentY) : null;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">:D</p>
<p style="padding: 0; margin: 8px;">maybe don't find and replace \
this</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop \
Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8526" \
rel="noreferrer">https://phabricator.kde.org/D8526</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic