[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8065: Ensure libinput connection thread uses real time scheduling
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-10-23 15:05:17
Message-ID: 20171023150515.44962.BCC008DB262DF773 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  Why didn't you just call gainRealTime again with reset_on_fork from the connection \
thread?  
  By creating it without and then changing the main thread after we've created the \
input thread, we're also putting your DBus thread, and the thread used by the fake \
QPA into realtime.  
  Probably won't do too much harm, but from the commit message I don't think you \
intended to that.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8065

To: graesslin, #kwin, #plasma
Cc: davidedmundson, anthonyfieroni, plasma-devel, kwin, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8065" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Why didn&#039;t you just call \
gainRealTime again with reset_on_fork from the connection thread?</p>

<p>By creating it without and then changing the main thread after we&#039;ve created \
the input thread, we&#039;re also putting your DBus thread, and the thread used by \
the fake QPA into realtime.</p>

<p>Probably won&#039;t do too much harm, but from the commit message I don&#039;t \
think you intended to that.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8065" \
rel="noreferrer">https://phabricator.kde.org/D8065</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: \
</strong>davidedmundson, anthonyfieroni, plasma-devel, kwin, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]