[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8398: [drm] Implement changing of modes
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-10-21 16:06:27
Message-ID: 20171021160626.49256.F052FF024280E9E7 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.


  In https://phabricator.kde.org/D8398#157766, @subdiff wrote:
  
  > Nice!
  >
  > You are using AMS on your testing machine I assume?
  
  
  Yes. I'm using defaults :-)
  
  > The mode change should currently not work in legacy mode, because \
`m_modesetRequested` gets only used by AMS. Without AMS you need to call directly \
`setModeLegacy` with a black buffer. Or maybe just test on `m_modesetRequested` in \
`presentLegacy` on the next present. This said is there the possibility that the next \
present won't come soon (also relevant for AMS, where the mode gets changed with the \
next present)?  
  Yeah, I already got from the code that my change won't work with legacy. And I'm \
tempted to just not implement it there. At least we could consider to not implement \
it and wait for a bug report. If we don't get one we could drop the complete legacy \
mode settings in ~1 year. That's the xorg style of deprecation: known breakage, \
waiting for someone notices.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8398

To: graesslin, #kwin, #plasma, subdiff, sebas
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8398" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8398#157766" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D8398#157766</a>, <a \
href="https://phabricator.kde.org/p/subdiff/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@subdiff</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Nice!</p>

<p>You are using AMS on your testing machine I assume?</p></div>
</blockquote>

<p>Yes. I&#039;m using defaults :-)</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The \
mode change should currently not work in legacy mode, because <tt style="background: \
#ebebeb; font-size: 13px;">m_modesetRequested</tt> gets only used by AMS. Without AMS \
you need to call directly <tt style="background: #ebebeb; font-size: \
13px;">setModeLegacy</tt> with a black buffer. Or maybe just test on <tt \
style="background: #ebebeb; font-size: 13px;">m_modesetRequested</tt> in <tt \
style="background: #ebebeb; font-size: 13px;">presentLegacy</tt> on the next present. \
This said is there the possibility that the next present won&#039;t come soon (also \
relevant for AMS, where the mode gets changed with the next \
present)?</p></blockquote>

<p>Yeah, I already got from the code that my change won&#039;t work with legacy. And \
I&#039;m tempted to just not implement it there. At least we could consider to not \
implement it and wait for a bug report. If we don&#039;t get one we could drop the \
complete legacy mode settings in ~1 year. That&#039;s the xorg style of deprecation: \
known breakage, waiting for someone notices.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8398" \
rel="noreferrer">https://phabricator.kde.org/D8398</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, subdiff, sebas<br /><strong>Cc: \
</strong>plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]