[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8398: [drm] Implement changing of modes
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-10-21 13:20:18
Message-ID: differential-rev-PHID-DREV-v7bzk7z2von4qzhnsxbk-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma, subdiff, sebas.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  This change hooks up the bits for changing the mode when a request to
  change mode from kscreen is received. This includes:
  
  - setting new mode in DrmOutput
  - creating new buffers in SceneQPainter backend
  - creating new GbmSurface in SceneOpenGL backend
  
  Room for improvement:
  
  - detect whether the new mode works and go back to old one if it fails

TEST PLAN
  Started both a QPainter/OpenGL session. Used kcmshell5 kscreen
  to modify the resolution. Saw that it got applied, maximized a window to
  verify it's correct. Changed back to original resolution. Verified it looked
  good by maximizing a window.

REPOSITORY
  R108 KWin

BRANCH
  drm-mode-changes

REVISION DETAIL
  https://phabricator.kde.org/D8398

AFFECTED FILES
  plugins/platforms/drm/drm_output.cpp
  plugins/platforms/drm/drm_output.h
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/drm/egl_gbm_backend.h
  plugins/platforms/drm/scene_qpainter_drm_backend.cpp

To: graesslin, #kwin, #plasma, subdiff, sebas
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma, subdiff, sebas.<br />Restricted Application added a project: \
KWin.<br />Restricted Application added subscribers: kwin, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8398" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>This change hooks up the bits for changing the mode when a \
request to<br /> change mode from kscreen is received. This includes:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">setting new mode in DrmOutput</li>
<li class="remarkup-list-item">creating new buffers in SceneQPainter backend</li>
<li class="remarkup-list-item">creating new GbmSurface in SceneOpenGL backend</li>
</ul>

<p>Room for improvement:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">detect whether the new mode works and go back to old \
one if it fails</li> </ul></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Started both a QPainter/OpenGL session. Used kcmshell5 \
kscreen<br /> to modify the resolution. Saw that it got applied, maximized a window \
to<br /> verify it&#039;s correct. Changed back to original resolution. Verified it \
looked<br /> good by maximizing a window.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>drm-mode-changes</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8398" \
rel="noreferrer">https://phabricator.kde.org/D8398</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>plugins/platforms/drm/drm_output.cpp<br /> \
plugins/platforms/drm/drm_output.h<br /> plugins/platforms/drm/egl_gbm_backend.cpp<br \
/> plugins/platforms/drm/egl_gbm_backend.h<br />
plugins/platforms/drm/scene_qpainter_drm_backend.cpp</div></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, subdiff, sebas<br /><strong>Cc: \
</strong>plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]