[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8390: Don't re-align outputs when QMLOutput in clone mode moves
From:       Daniel_Vrátil <noreply () phabricator ! kde ! org>
Date:       2017-10-21 7:16:29
Message-ID: differential-rev-PHID-DREV-6xjmsn6hgquwuawubham-req () phabricator ! kde ! org
[Download RAW message or body]

dvratil created this revision.
dvratil added a reviewer: sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Changing resolution of the 'Unified output' makes it move around which
  then triggers QMLScreen::qmlOutputMoved() which tries to snap and re-align
  all the outputs. This leads to the KScreen Outputs being positioned next
  to each other in the final KScreen Config that is uploaded to KDED,
  instead of on top of each other, virtually breaking the 'Unify outputs'
  feature.

TEST PLAN
  Click 'Unify outputs' and change resolution of the unified screen. Click apply.
  Resolution changes on both screens and they are now are correctly repositioned
  to be in clone mode.

REPOSITORY
  R104 KScreen

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8390

AFFECTED FILES
  kcm/src/declarative/qmlscreen.cpp

To: dvratil, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">dvratil created this revision.<br />dvratil added a reviewer: \
sebas.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8390" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Changing \
resolution of the &#039;Unified output&#039; makes it move around which<br /> then \
triggers QMLScreen::qmlOutputMoved() which tries to snap and re-align<br /> all the \
outputs. This leads to the KScreen Outputs being positioned next<br /> to each other \
in the final KScreen Config that is uploaded to KDED,<br /> instead of on top of each \
other, virtually breaking the &#039;Unify outputs&#039;<br /> \
feature.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Click \
&#039;Unify outputs&#039; and change resolution of the unified screen. Click \
apply.<br /> Resolution changes on both screens and they are now are correctly \
repositioned<br /> to be in clone mode.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>Plasma/5.11</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8390" \
rel="noreferrer">https://phabricator.kde.org/D8390</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kcm/src/declarative/qmlscreen.cpp</div></div></div><br \
/><div><strong>To: </strong>dvratil, sebas<br /><strong>Cc: </strong>plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]