[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8232: Add option to center shadow
From: Hugo Pereira Da Costa <noreply () phabricator ! kde ! org>
Date: 2017-10-18 17:58:43
Message-ID: 20171018175842.122947.100B0F56EE0DFBD6 () phabricator ! kde ! org
[Download RAW message or body]
hpereiradacosta added a comment.
In https://phabricator.kde.org/D8232#156934, @mvourlakos wrote:
> In https://phabricator.kde.org/D8232#155519, @alake wrote:
>
> > Ok, I agree now that there shouldn't be an option. I think it is fair to say \
that the contrast on the left side of overlapping windows could be improved. The \
proposed compromise solution actually looks decent too and it keeps the lighting \
reasonably consistent. The VDG and Hugo are discussing. Oh and in case it is \
sometimes forgotten, thanks for submitting the patch. :-) >
>
> did you end up in any decision concerning the left shadow improvement?
I think the consensus (from Telegram discussions) was that I would submit two \
review requests to superseed this one:
- one where the whole of breeze is now centered (shadows for windows, buttons, \
etc.), which would be a "consistent" extension of the present patch;
- one where breeze is left largely unchanged but the window shadow modified to \
"bleed" more on the left and the top, while keeping it top-left oriented, that would \
be consistent with your proposed screenshots.
This would allow people (including designer) to test both in real life, possibly \
offer suggestions for improvement, and ultimately we decide between one solution or \
the other.
I'm still working on the patches though. Will take a bit of time (~a week)
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D8232
To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, \
davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
sebas, apol
[Attachment #3 (unknown)]
<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8232" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8232#156934" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8232#156934</a>, <a \
href="https://phabricator.kde.org/p/mvourlakos/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@mvourlakos</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8232#155519" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D8232#155519</a>, <a \
href="https://phabricator.kde.org/p/alake/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@alake</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Ok, I agree now that there shouldn't be \
an option. I think it is fair to say that the contrast on the left side of \
overlapping windows could be improved. The proposed compromise solution actually \
looks decent too and it keeps the lighting reasonably consistent. The VDG and Hugo \
are discussing. Oh and in case it is sometimes forgotten, thanks for submitting the \
patch. :-)</p></div> </blockquote>
<p>did you end up in any decision concerning the left shadow improvement?</p></div>
</blockquote>
<p>I think the consensus (from Telegram discussions) was that I would submit two \
review requests to superseed this one:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">one where the whole of breeze is now centered (shadows \
for windows, buttons, etc.), which would be a "consistent" extension of the \
present patch;</li> <li class="remarkup-list-item">one where breeze is left largely \
unchanged but the window shadow modified to "bleed" more on the left and \
the top, while keeping it top-left oriented, that would be consistent with your \
proposed screenshots.</li> </ul>
<p>This would allow people (including designer) to test both in real life, possibly \
offer suggestions for improvement, and ultimately we decide between one solution or \
the other.</p>
<p>I'm still working on the patches though. Will take a bit of time (~a \
week)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 \
Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8232" \
rel="noreferrer">https://phabricator.kde.org/D8232</a></div></div><br \
/><div><strong>To: </strong>rpelorosso, Breeze, VDG, hpereiradacosta<br /><strong>Cc: \
</strong>januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, \
davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic