[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8065: Ensure libinput connection thread uses real time scheduling
From:       Anthony Fieroni <noreply () phabricator ! kde ! org>
Date:       2017-10-17 4:32:56
Message-ID: 20171017043254.106905.E9256B756052B0D4 () phabricator ! kde ! org
[Download RAW message or body]

anthonyfieroni added inline comments.

INLINE COMMENTS

> graesslin wrote in main_wayland.cpp:91
> Could you please explain why you think that this function should be static? Please \
> keep in mind that main_wayland.cpp is it's own translation unit.

It does not have other purpose, i don't see it's only one unit.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8065

To: graesslin, #kwin, #plasma
Cc: anthonyfieroni, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8065" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8065#inline-35260" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">graesslin</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">main_wayland.cpp:91</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Could you please explain why you \
think that this function should be static? Please keep in mind that main_wayland.cpp \
is it&#039;s own translation unit.</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">It does not have other purpose, \
i don&#039;t see it&#039;s only one unit.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8065" \
rel="noreferrer">https://phabricator.kde.org/D8065</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: \
</strong>anthonyfieroni, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]