[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8040: Load QtQuick settings
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-09-29 17:09:18
Message-ID: 20170929170917.71398.606D59DE716CE204 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.


  In https://phabricator.kde.org/D8040#150577, @davidedmundson wrote
  
  > If you do want to set this based on the initial scene backend, skip using this \
method and call the static method on QQuickWindow instead.  
  
  After reading through the docs I think the combination of both is fine: We can use \
the QtQuickSettings to have a base. But if we init a QPainter compositor we just \
enforce software through the QQuickWindow API. That should (TM) work as well. Dynamic \
switching is then not required. AFAIK the only "dangerous" combination would be \
QPainter compositor and OpenGL compositing. The other 3 combinations should just work \
fine.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8040

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8040" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8040#150577" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D8040#150577</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>If you do want to set this based on the \
initial scene backend, skip using this method and call the static method on \
QQuickWindow instead.</p></div> </blockquote>

<p>After reading through the docs I think the combination of both is fine: We can use \
the QtQuickSettings to have a base. But if we init a QPainter compositor we just \
enforce software through the QQuickWindow API. That should (TM) work as well. Dynamic \
switching is then not required. AFAIK the only &quot;dangerous&quot; combination \
would be QPainter compositor and OpenGL compositing. The other 3 combinations should \
just work fine.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8040" \
rel="noreferrer">https://phabricator.kde.org/D8040</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, graesslin<br /><strong>Cc: \
</strong>graesslin, plasma-devel, kwin, KWin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]