[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8050: Expose wl_display_set_global_filter as a virtual method
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-09-29 14:38:33
Message-ID: 20170929143801.99379.076719DACB2056EF () phabricator ! kde ! org
[Download RAW message or body]

graesslin added inline comments.

INLINE COMMENTS

> filtered_display.cpp:62
> +        }
> +        wl_display_set_global_filter(*this, Private::globalFilterCallback, \
> d.data()); +    });

I didn't know such API exists! This is great ;-)

But I think you need to increase the minimum Wayland version.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8050

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8050" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8050#inline-33528" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">filtered_display.cpp:62</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">}</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">        <span class="n">wl_display_set_global_filter</span><span \
class="p">(</span><span style="color: #aa2211">*</span><span style="color: \
#aa4000">this</span><span class="p">,</span> <span class="n">Private</span><span \
style="color: #aa2211">::</span><span class="n">globalFilterCallback</span><span \
class="p">,</span> <span class="n">d</span><span class="p">.</span><span \
class="n">data</span><span class="p">());</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">});</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">I didn&#039;t know such API exists! This is great ;-)</p>

<p style="padding: 0; margin: 8px;">But I think you need to increase the minimum \
Wayland version.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8050" \
rel="noreferrer">https://phabricator.kde.org/D8050</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>graesslin, plasma-devel, Frameworks, leezu, ZrenBot, alexeymin, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]