[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8054: Show headset icons for devices identifying as "Headset" in Description
From: David Rosca <noreply () phabricator ! kde ! org>
Date: 2017-09-29 12:53:07
Message-ID: 20170929125226.115490.A22967FBE22A5603 () phabricator ! kde ! org
[Download RAW message or body]
drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.
Perfect solution!
But why is it in Profile when it is device property? Just remove it from Profile \
and leave it only in Device.
INLINE COMMENTS
> DeviceListItem.qml:30
> if (currentPort) {
> - if (currentPort.name.indexOf("speaker") != -1) {
> - return "audio-speakers-symbolic";
> - } else if (currentPort.name.indexOf("headphones") != -1) {
> - return "audio-headphones";
> - } else if (currentPort.name.indexOf("hdmi") != -1) {
> - return "video-television";
> - } else if (currentPort.name.indexOf("mic") != -1) {
> - return "audio-input-microphone";
> - } else if (currentPort.name.indexOf("phone") != -1) {
> - return "phone";
> + switch(currentPort.formFactor) {
> + case "internal":
Form factor will be the same for all ports, so just use `switch (FormFactor)`
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson, drosca
Cc: drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">drosca requested changes to this revision.<br />drosca added \
a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8054" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Perfect \
solution!</p>
<p>But why is it in Profile when it is device property? Just remove it from Profile \
and leave it only in Device.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8054#inline-33512" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">DeviceListItem.qml:30</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span style="color: #004012">currentPort</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(251, 175, 175, .7);"> <span \
class="bright"></span><span style="color: #aa4000"><span \
class="bright">if</span></span><span class="bright"> </span><span \
class="p">(</span><span style="color: #004012">currentPort</span><span \
class="p">.<span class="bright"></span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">name</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">indexOf</span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span style="color: \
#766510"><span class="bright">"speaker"</span></span><span \
class="bright"></span><span class="p"><span class="bright">)</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">!=</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">-</span></span><span class="bright"></span><span \
style="color: #601200"><span class="bright">1</span></span><span class="p">)</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: \
#aa4000"><span class="bright">switch</span></span><span class="p">(</span><span \
style="color: #004012">currentPort</span><span class="p">.<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#004012"><span class="bright">formFactor</span></span><span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">case</span> \
<span style="color: #766510">"internal"</span><span style="color: \
#aa2211">:</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Form \
factor will be the same for all ports, so just use <tt style="background: #ebebeb; \
font-size: 13px;">switch (FormFactor)</tt></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8054" \
rel="noreferrer">https://phabricator.kde.org/D8054</a></div></div><br \
/><div><strong>To: </strong>antlarr, Plasma, davidedmundson, drosca<br /><strong>Cc: \
</strong>drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic