[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8026: [Activity KCM] Disallow adding/removing activity when restricted
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-09-28 11:52:24
Message-ID: differential-rev-PHID-DREV-t5jolp6gqchgks5pekz7-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
broulik added reviewers: Plasma, ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The `plasma-desktop/add_activities` will disallow adding and removing activities \
from the Activity Manager in Plasma. However, the KCM would allow to do so \
regardless.

TEST PLAN
  Placed the following in `kdeglobals`:
  
    [KDE Action Restrictions]
    plasma-desktop/add_activities=false
  
  Was no longer able to add or remove activities from Activity KCM. Without this it \
works as before.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8026

AFFECTED FILES
  kcms/activities/qml/activitiesTab/ActivitiesView.qml

To: broulik, #plasma, ivan
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, ivan.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8026" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The <tt \
style="background: #ebebeb; font-size: 13px;">plasma-desktop/add_activities</tt> will \
disallow adding and removing activities from the Activity Manager in Plasma. However, \
the KCM would allow to do so regardless.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Placed the following in <tt style="background: #ebebeb; \
font-size: 13px;">kdeglobals</tt>:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">[KDE Action Restrictions] \
plasma-desktop/add_activities=false</pre></div>

<p>Was no longer able to add or remove activities from Activity KCM. Without this it \
works as before.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 \
Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8026" \
rel="noreferrer">https://phabricator.kde.org/D8026</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kcms/activities/qml/activitiesTab/ActivitiesView.qml</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, ivan<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]