[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8012: Only assert on broken GL when we're rendering using GL
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-09-27 15:20:14
Message-ID: 20170927152009.111339.BE2FD26535E2C05C () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in desktopview.cpp:60
> Is it correct to compare to software? What if vulkan get's introduced?

Then we change it..

The reason it's done this way round is currently is that \
setSceneGraph("aaerkwlakrjaldkfj") will result in it being GL.

They seem to be migrating to using enums, which will make life better in the future.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8012

To: davidedmundson, #plasma, broulik
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8012" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8012#inline-33258" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">graesslin</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">desktopview.cpp:60</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Is it correct to compare to \
software? What if vulkan get&#039;s introduced?</p></div></div> <div style="margin: \
8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Then we change it..</p>

<p style="padding: 0; margin: 8px;">The reason it&#039;s done this way round is \
currently is that setSceneGraph(&quot;aaerkwlakrjaldkfj&quot;) will result in it \
being GL.</p>

<p style="padding: 0; margin: 8px;">They seem to be migrating to using enums, which \
will make life better in the future.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8012" \
rel="noreferrer">https://phabricator.kde.org/D8012</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, broulik<br /><strong>Cc: \
</strong>graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]