[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8009: [Containment Interface] Don't add containment actions to applet actions on desktop
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-09-27 13:28:52
Message-ID: differential-rev-PHID-DREV-fsrxjnztiqowxqg3ovwv-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  For a panel it makes sense to have panel options easily available on every applet \
but on the desktop you typically have some free space to access the containment \
actions.  This is especially confusing if you have a Folder View on your Folder View \
desktop and end up with a "Folder View Options" menu that affects the desktop behind \
it rather than the applet.

TEST PLAN
  Right clicked applet on desktop, no longer get "Foldre View Options" submenu. On \
panel I still get "Panel Options" menu

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8009

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: \
Plasma.<br />Restricted Application added projects: Plasma, Frameworks.<br \
/>Restricted Application added subscribers: Frameworks, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8009" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>For a panel it makes sense to have panel options easily \
available on every applet but on the desktop you typically have some free space to \
access the containment actions.<br /> This is especially confusing if you have a \
Folder View on your Folder View desktop and end up with a &quot;Folder View \
Options&quot; menu that affects the desktop behind it rather than the \
applet.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Right clicked \
applet on desktop, no longer get &quot;Foldre View Options&quot; submenu. On panel I \
still get &quot;Panel Options&quot; menu</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8009" \
rel="noreferrer">https://phabricator.kde.org/D8009</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/scriptengines/qml/plasmoid/containmentinterface.cpp</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, \
Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]