[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8006: Add edit button to desktop theme
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-09-27 11:28:04
Message-ID: differential-rev-PHID-DREV-ltupxroh6xchxin22222-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This option is only visible in plasmathemeexplorer is installed. This
  makes it easy to edit themes, without cluttering the UI of normal users.
  
  Edit button is made similar to the action buttons in the wallpaper
  delegate. (though this is copying an existing bug of of using
  plasmacomponents where they shouldn't be)
  
  MouseArea got collapsed into the parent Item in the delegate as it makes
  for more readable implicit z-ordering to have the button on top.

TEST PLAN
  Clicked on one, explorer for that theme appeared.
  Faked not having theme explorer by temporarily putting a typo in the service name. No buttons showed

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8006

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8006" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>This option is only visible in plasmathemeexplorer is \
installed. This<br /> makes it easy to edit themes, without cluttering the UI of \
normal users.</p>

<p>Edit button is made similar to the action buttons in the wallpaper<br />
delegate. (though this is copying an existing bug of of using<br />
plasmacomponents where they shouldn&#039;t be)</p>

<p>MouseArea got collapsed into the parent Item in the delegate as it makes<br />
for more readable implicit z-ordering to have the button on top.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Clicked on one, explorer for that theme \
appeared.<br /> Faked not having theme explorer by temporarily putting a typo in the \
service name. No buttons showed</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8006" \
rel="noreferrer">https://phabricator.kde.org/D8006</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kcms/desktoptheme/CMakeLists.txt<br \
/> kcms/desktoptheme/kcm.cpp<br />
kcms/desktoptheme/kcm.h<br />
kcms/desktoptheme/package/contents/ui/main.qml</div></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]