[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7940: plugin loaded by kirigami to use KColorScheme and KIconLoader
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-09-26 12:38:56
Message-ID: 20170926123844.56905.7B9273518C83C784 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in plasmadesktoptheme.cpp:34
> I can't find Kirigami::PlatformTheme? Is the review published?

it's in the giant https://phabricator.kde.org/D7939

> davidedmundson wrote in plasmadesktoptheme.h:73
> how are they legacy?

should be better documented...
the idea is to go from
Rectangle {

  color: Theme.viewBackgroundColor

}

to

Rectangle {

  Theme.colorSet: Theme.View
  color: Theme.backgroundColor

}

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7940

To: mart, #plasma, #kirigami, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7940" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7940#inline-33003" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">plasmadesktoptheme.cpp:34</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I can&#039;t find \
Kirigami::PlatformTheme? Is the review published?</p></div></div> <div style="margin: \
8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it&#039;s in the giant \
<a href="https://phabricator.kde.org/D7939" class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/D7939</a></p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7940#inline-33001" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">davidedmundson</span> \
wrote in <span style="color: #4b4d51; font-weight: \
bold;">plasmadesktoptheme.h:73</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">how are they \
legacy?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">should be better documented...<br /> the idea is to \
go from<br /> Rectangle {</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">color: \
Theme.viewBackgroundColor</pre></div>

<p style="padding: 0; margin: 8px;">}</p>

<p style="padding: 0; margin: 8px;">to</p>

<p style="padding: 0; margin: 8px;">Rectangle {</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
                12px; margin: 0; background: rgba(71, 87, 120, \
                0.08);">Theme.colorSet: Theme.View
color: Theme.backgroundColor</pre></div>

<p style="padding: 0; margin: 8px;">}</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in \
Plasma</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7940" \
rel="noreferrer">https://phabricator.kde.org/D7940</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, Kirigami, hein<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]