[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7937: Don't reload background contrast effect on screen resize
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-09-22 13:33:37
Message-ID: 20170922133311.20962.E3BF63DCC0C60D28 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added inline comments.

INLINE COMMENTS

> contrast.cpp:79
> +    }
> +    foreach (EffectWindow *window, effects->stackingOrder())
> +        updateContrastRegion(window);

please no foreach in new code, please use range-based for. (Reason: I don't trust Qt \
to keep it after there was a prominent blog post about deprecating foreach)

> contrast.cpp:79-80
> +    }
> +    foreach (EffectWindow *window, effects->stackingOrder())
> +        updateContrastRegion(window);
> }

Please use {}

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7937

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7937" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7937#inline-32764" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">contrast.cpp:79</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span class="p">}</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">foreach</span> <span class="p">(</span><span class="n">EffectWindow</span> \
<span style="color: #aa2211">*</span><span class="n">window</span><span \
class="p">,</span> <span class="n">effects</span><span style="color: \
#aa2211">-&gt;</span><span class="n">stackingOrder</span><span class="p">())</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">        <span class="n">updateContrastRegion</span><span \
class="p">(</span><span class="n">window</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">please no foreach in new code, please use range-based for. (Reason: I \
don&#039;t trust Qt to keep it after there was a prominent blog post about \
deprecating foreach)</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D7937#inline-32762" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">contrast.cpp:79-80</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span class="p">}</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">foreach</span> <span class="p">(</span><span class="n">EffectWindow</span> \
<span style="color: #aa2211">*</span><span class="n">window</span><span \
class="p">,</span> <span class="n">effects</span><span style="color: \
#aa2211">-&gt;</span><span class="n">stackingOrder</span><span class="p">())</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">        <span class="n">updateContrastRegion</span><span \
class="p">(</span><span class="n">window</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Please use {}</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7937" \
rel="noreferrer">https://phabricator.kde.org/D7937</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>graesslin, plasma-devel, kwin, KWin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]