[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7897: Move X11 specific Workspace initialization code into dedicated method
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-09-20 20:08:48
Message-ID: 20170920200843.21042.B0F707872ED78D45 () phabricator ! kde ! org
[Download RAW message or body]

broulik added inline comments.

INLINE COMMENTS

> workspace.cpp:381
> +
> +    xcb_change_property(connection(), XCB_PROP_MODE_APPEND, rootWindow(), \
> atoms->kwin_running, +                        atoms->kwin_running, 32, 1, &data);

`kwinApp()->x11Connection()`?

> workspace.cpp:397
> +
> +    // TODO: only in X11 mode
> +    // Extra NETRootInfo instance in Client mode is needed to get the values of \
> the properties

Now superfluous, also below

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7897

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7897" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7897#inline-32642" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">workspace.cpp:381</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span \
class="n">xcb_change_property</span><span class="p">(</span><span \
class="n">connection</span><span class="p">(),</span> <span \
class="n">XCB_PROP_MODE_APPEND</span><span class="p">,</span> <span \
class="n">rootWindow</span><span class="p">(),</span> <span \
class="n">atoms</span><span style="color: #aa2211">-&gt;</span><span \
class="n">kwin_running</span><span class="p">,</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        \
<span class="n">atoms</span><span style="color: #aa2211">-&gt;</span><span \
class="n">kwin_running</span><span class="p">,</span> <span style="color: \
#601200">32</span><span class="p">,</span> <span style="color: #601200">1</span><span \
class="p">,</span> <span style="color: #aa2211">&amp;</span><span \
class="n">data</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt \
style="background: #ebebeb; font-size: \
13px;">kwinApp()-&gt;x11Connection()</tt>?</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7897#inline-32643" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">workspace.cpp:397</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// TODO: only \
in X11 mode</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span style="color: #74777d">// Extra NETRootInfo \
instance in Client mode is needed to get the values of the properties</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Now superfluous, also below</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7897" \
rel="noreferrer">https://phabricator.kde.org/D7897</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: \
</strong>broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]