[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D7856: Make xstacking order dirty handling work without X11
From: Martin_Flöser <noreply () phabricator ! kde ! org>
Date: 2017-09-17 7:31:04
Message-ID: differential-rev-PHID-DREV-67hq5u6gib6yrk72dskw-req () phabricator ! kde ! org
[Download RAW message or body]
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The xStackingOrder unlike indicated by it's name is relevant for both
X11 and Wayland and contains the stacking order of the windows used for
compositing.
So far it was determined whether it needs to be recreated based on
whether an xcb query is pending. This change introduces a boolean
variable to check whether the stacking order is dirty and guards the X11
specific code to only be run if we have an X11 connection.
This is to my current knowledge the last remaining issue where X11 was
used during the normal Wayland operation mode. Now it should be possible
to re-order the Workspace startup [1] and try to run kwin_wayland without
Wayland support.
[1] Workspace::Workspace and Workspace::init is still highly X11
specific and needs to be split into X11 only and general parts.
TEST PLAN
Compiles
REPOSITORY
R108 KWin
BRANCH
xstacking-dirty-no-x11
REVISION DETAIL
https://phabricator.kde.org/D7856
AFFECTED FILES
layers.cpp
workspace.cpp
workspace.h
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma.<br />Restricted Application added a project: KWin.<br \
/>Restricted Application added subscribers: kwin, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7856" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>The xStackingOrder unlike indicated by it's name is \
relevant for both<br /> X11 and Wayland and contains the stacking order of the \
windows used for<br /> compositing.</p>
<p>So far it was determined whether it needs to be recreated based on<br />
whether an xcb query is pending. This change introduces a boolean<br />
variable to check whether the stacking order is dirty and guards the X11<br />
specific code to only be run if we have an X11 connection.</p>
<p>This is to my current knowledge the last remaining issue where X11 was<br />
used during the normal Wayland operation mode. Now it should be possible<br />
to re-order the Workspace startup [1] and try to run kwin_wayland without<br />
Wayland support.</p>
<p>[1] Workspace::Workspace and Workspace::init is still highly X11<br />
specific and needs to be split into X11 only and general parts.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Compiles</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>xstacking-dirty-no-x11</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7856" \
rel="noreferrer">https://phabricator.kde.org/D7856</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>layers.cpp<br /> workspace.cpp<br />
workspace.h</div></div></div><br /><div><strong>To: </strong>graesslin, KWin, \
Plasma<br /><strong>Cc: </strong>plasma-devel, kwin, bwowk, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic