[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2017-09-12 11:51:19
Message-ID: 20170912115116.42178.6A19D2829FE2DC0C () phabricator ! kde ! org
[Download RAW message or body]

subdiff added a comment.


  In https://phabricator.kde.org/D7768#145079, @davidedmundson wrote:
  
  > So now you copy to the data of toolTipDelegate.parentTask when the mouse leaves? 
  >  Why does that help?
  
  
  Good question. I don't understand how it helps, but it does. Somehow the model data \
needs to be copied an additional time to the delegate. It's something deeper \
probably, because without this patch (and only my other one) I even get seg faults \
when after I do manually change the task order I quickly raise another tooltip.  
  If you find a better solution, come forward. Otherwise I could also add a comment \
in the code explaining why we always copy the data.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: subdiff, #plasma
Cc: hein, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7768" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7768#145079" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D7768#145079</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>So now you copy to the data of \
toolTipDelegate.parentTask when the mouse leaves? <br />  Why does that \
help?</p></div> </blockquote>

<p>Good question. I don&#039;t understand how it helps, but it does. Somehow the \
model data needs to be copied an additional time to the delegate. It&#039;s something \
deeper probably, because without this patch (and only my other one) I even get seg \
faults when after I do manually change the task order I quickly raise another \
tooltip.</p>

<p>If you find a better solution, come forward. Otherwise I could also add a comment \
in the code explaining why we always copy the data.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7768" \
rel="noreferrer">https://phabricator.kde.org/D7768</a></div></div><br \
/><div><strong>To: </strong>subdiff, Plasma<br /><strong>Cc: </strong>hein, \
davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]