[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D3805: Per-activity favorites (Final, again?)
From:       Eike Hein <noreply () phabricator ! kde ! org>
Date:       2017-09-08 13:56:14
Message-ID: 20170908135611.108625.6B6CC262970E9746 () phabricator ! kde ! org
[Download RAW message or body]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  So I assume the bug was that I was getting too many favorites? Limit::all is now \
unlimited I assume? Otherwise it needs to be integrated with the maxFavorites stuff \
to disable the actions. (Does maxFavorites still work BTW? Because it's needed for \
Simple Menu on the KDE Store.)  
  (Just realized due to the API changes this will probably break Simple Menu anyway \
... then again it was using the non-public Kicker backend ... I need to talk to you \
how I can get migration for Simple Menu too.)  
  Alright, let's merge now then - I didn't actually have time to re-test this but I \
guess the bug/fix is obvious in retrospect and it was working fine otherwise.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D3805

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">hein accepted this revision.<br />hein added a comment.<br \
/>This revision is now accepted and ready to land. </td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3805" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>So I assume the bug was that I was \
getting too many favorites? Limit::all is now unlimited I assume? Otherwise it needs \
to be integrated with the maxFavorites stuff to disable the actions. (Does \
maxFavorites still work BTW? Because it&#039;s needed for Simple Menu on the KDE \
Store.)</p>

<p>(Just realized due to the API changes this will probably break Simple Menu anyway \
... then again it was using the non-public Kicker backend ... I need to talk to you \
how I can get migration for Simple Menu too.)</p>

<p>Alright, let&#039;s merge now then - I didn&#039;t actually have time to re-test \
this but I guess the bug/fix is obvious in retrospect and it was working fine \
otherwise.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>arcpatch-D3805</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3805" \
rel="noreferrer">https://phabricator.kde.org/D3805</a></div></div><br \
/><div><strong>To: </strong>ivan, mart, hein<br /><strong>Cc: </strong>Zren, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]