[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7155: Implement sorting of the device tree items
From:       Isaac True <noreply () phabricator ! kde ! org>
Date:       2017-09-04 19:19:02
Message-ID: 20170904191859.33820.B5B61D7B9AC9A2B0 () phabricator ! kde ! org
[Download RAW message or body]

isaact marked 6 inline comments as done.
isaact added a comment.


  Thanks for the feedback - diff has been updated

INLINE COMMENTS

> broulik wrote in devicelisting.cpp:49
> Why disable again?

I've removed the disable as it's pointless

> anthonyfieroni wrote in soldevice.cpp:165
> left->number() < right->number() ?

This is reversed as it's sorted in the opposite order (ascending) to the other \
entries (descending)

> anthonyfieroni wrote in soldevice.cpp:169
> Reverse again ?

These are also sorted in ascending order, so that it goes from sda1, sda2, etc.

> anthonyfieroni wrote in soldevice.h:108
> Why virtual ?

Habit - removed

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7155

To: isaact, #plasma, cfeck
Cc: cfeck, broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">isaact marked 6 inline comments as done.<br />isaact added a \
comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7155" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Thanks for the feedback - diff has been \
updated</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7155#inline-29153" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">devicelisting.cpp:49</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Why disable \
again?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">I&#039;ve removed the disable as it&#039;s \
pointless</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7155#inline-29145" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">anthonyfieroni</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">soldevice.cpp:165</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">left-&gt;number() &lt; \
right-&gt;number() ?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">This is reversed as it&#039;s sorted in the opposite \
order (ascending) to the other entries (descending)</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7155#inline-29147" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">anthonyfieroni</span> \
wrote in <span style="color: #4b4d51; font-weight: \
bold;">soldevice.cpp:169</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Reverse again ?</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">These are also sorted in ascending order, so that it goes from sda1, sda2, \
etc.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7155#inline-29144" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">anthonyfieroni</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">soldevice.h:108</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Why virtual ?</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Habit - removed</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7155" \
rel="noreferrer">https://phabricator.kde.org/D7155</a></div></div><br \
/><div><strong>To: </strong>isaact, Plasma, cfeck<br /><strong>Cc: </strong>cfeck, \
broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]