[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D3805: Per-activity favorites (Final, again?)
From:       Ivan Čukić <noreply () phabricator ! kde ! org>
Date:       2017-09-01 5:40:54
Message-ID: 20170901054046.47635.5BE2FF9909174FBD () phabricator ! kde ! org
[Download RAW message or body]

ivan added a comment.


  > Good news: There's actually nothing to do on the favorite ids, Kicker already \
uses   >  KService::storageId as favorite id, which will be the menuId when it's \
available.  
  Great :)
  
  > I didn't write the Kickoff UI code btw so I don't know about the empty places \
issue, but I can try to have a look,  
  That would be much appreciated, so that I can find a ordering hack that works :)

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">ivan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3805" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>Good news: There&#039;s actually nothing to do on the \
favorite ids, Kicker already uses <br />  KService::storageId as favorite id, which \
will be the menuId when it&#039;s available.</p></blockquote>

<p>Great :)</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I \
didn&#039;t write the Kickoff UI code btw so I don&#039;t know about the empty places \
issue, but I can try to have a look,</p></blockquote>

<p>That would be much appreciated, so that I can find a ordering hack that works \
:)</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3805" \
rel="noreferrer">https://phabricator.kde.org/D3805</a></div></div><br \
/><div><strong>To: </strong>ivan, mart, hein<br /><strong>Cc: </strong>Zren, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]