--785b9bcdbdb643d29b8bfe7ef74d4ad2
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

hein added a comment.


  Good news: There's actually nothing to do on the favorite ids, Kicker already uses KService::storageId as favorite id, which will be the menuId when it's available.
  
  Due to Kai giving me https://bugs.kde.org/show_bug.cgi?id=351553 I thought this was an issue, but this is actually about the old Kickoff backend from before it was ported to Kicker.
  
  I didn't write the Kickoff UI code btw so I don't know about the empty places issue, but I can try to have a look,

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

--785b9bcdbdb643d29b8bfe7ef74d4ad2
Content-Transfer-Encoding: 7bit
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style="">hein added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3805" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Good news: There&#039;s actually nothing to do on the favorite ids, Kicker already uses KService::storageId as favorite id, which will be the menuId when it&#039;s available.</p>

<p>Due to Kai giving me <a href="https://bugs.kde.org/show_bug.cgi?id=351553" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=351553</a> I thought this was an issue, but this is actually about the old Kickoff backend from before it was ported to Kicker.</p>

<p>I didn&#039;t write the Kickoff UI code btw so I don&#039;t know about the empty places issue, but I can try to have a look,</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3805" rel="noreferrer">https://phabricator.kde.org/D3805</a></div></div><br /><div><strong>To: </strong>ivan, mart, hein<br /><strong>Cc: </strong>Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>
--785b9bcdbdb643d29b8bfe7ef74d4ad2--