From kde-panel-devel  Thu Aug 31 09:51:09 2017
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: Thu, 31 Aug 2017 09:51:09 +0000
To: kde-panel-devel
Subject: D7624: [Containment Actions Config] Cleanup layout and support multiple modifiers
Message-Id: <differential-rev-PHID-DREV-rgfg3nnvppuigm7nfm3z-req () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=150417308227391
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--ffceedef4b1a4a2bb015cafd1b3203f2"

--ffceedef4b1a4a2bb015cafd1b3203f2
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Currently we only manage to display one modifier for each action but you can setup multiple (which work fine, it's just the UI).
  While at it, port it to a GridLayout to ensure action buttons adjust their width and don't blow up the layout or truncate.

TEST PLAN
  F3891505: Screenshot_20170831_114957.png <https://phabricator.kde.org/F3891505>

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7624

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentActions.qml
  desktoppackage/contents/configuration/MouseEventInputButton.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

--ffceedef4b1a4a2bb015cafd1b3203f2
Content-Transfer-Encoding: 7bit
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style="">broulik created this revision.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7624" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Currently we only manage to display one modifier for each action but you can setup multiple (which work fine, it&#039;s just the UI).<br />
While at it, port it to a GridLayout to ensure action buttons adjust their width and don&#039;t blow up the layout or truncate.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p><a href="https://phabricator.kde.org/F3891505" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F3891505: Screenshot_20170831_114957.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7624" rel="noreferrer">https://phabricator.kde.org/D7624</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>desktoppackage/contents/configuration/ConfigurationContainmentActions.qml<br />
desktoppackage/contents/configuration/MouseEventInputButton.qml</div></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>
--ffceedef4b1a4a2bb015cafd1b3203f2--