[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2017-08-29 20:57:14
Message-ID: 20170829205714.31785.27194 () mimi ! kde ! org
[Download RAW message or body]
--===============2856433134715147818==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/
-----------------------------------------------------------
(Updated Aug. 29, 2017, 8:57 nachm.)
Status
------
This change has been discarded.
Review request for Plasma.
Repository: plasma-framework
Description
-------
QMenu is smart enough not to position itself outside the screen, however this can \
mean that the button the Menu originated from, could be covered. This can be observed \
with Widget Explorer's "get more widgets" buttons.
Diffs
-----
src/declarativeimports/plasmacomponents/qmenu.cpp d84f481
Diff: https://git.reviewboard.kde.org/r/126061/diff/
Testing
-------
Ran the menu.qml test and moved the window around, positioning seemed sane. Also \
Widget Explorer more menu now pops up to the top.
I subtract the Y from the position to not break the most common usecase of popup(0, \
height) to have the menu pop up below the button. Now it pops up above it, still \
glued to it as it should be.
Thanks,
Kai Uwe Broulik
--===============2856433134715147818==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126061/">https://git.reviewboard.kde.org/r/126061/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2017, 8:57 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">QMenu is smart enough not to position itself outside \
the screen, however this can mean that the button the Menu originated from, could be \
covered. This can be observed with Widget Explorer's "get more widgets" \
buttons.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran the menu.qml test and moved the window around, \
positioning seemed sane. Also Widget Explorer more menu now pops up to the top.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I subtract the Y from the position to not break the \
most common usecase of popup(0, height) to have the menu pop up below the button. Now \
it pops up above it, still glued to it as it should be.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmacomponents/qmenu.cpp <span style="color: \
grey">(d84f481)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126061/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2856433134715147818==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic