[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7586: [Folder View] Delay delegate creation until plasmoid expands
From:       Eike Hein <noreply () phabricator ! kde ! org>
Date:       2017-08-28 15:34:46
Message-ID: 20170828153444.53665.AE79B1F9F8203BDE () phabricator ! kde ! org
[Download RAW message or body]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  > The listingCompleted property could be moved into the FolderModel
  
  I think it's better to have seperate signals for start and stop here to reinforce \
the transactional nature ... if this was moved into FM it should be a enum similar to \
Loader.status imho (which would be nice for sure).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7586

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">hein accepted this revision.<br />hein added a comment.<br \
/>This revision is now accepted and ready to land. </td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7586" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>The listingCompleted property could be moved into the \
FolderModel</p></blockquote>

<p>I think it&#039;s better to have seperate signals for start and stop here to \
reinforce the transactional nature ... if this was moved into FM it should be a enum \
similar to Loader.status imho (which would be nice for sure).</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7586" \
rel="noreferrer">https://phabricator.kde.org/D7586</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]