[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D7087: WIP: Add menu with "Copy to Clipboard" to the About System module
From: gregormi <noreply () phabricator ! kde ! org>
Date: 2017-08-03 10:10:39
Message-ID: 20170803101038.6104.A878EE2C953287CC () phabricator ! kde ! org
[Download RAW message or body]
gregormi added a comment.
In https://phabricator.kde.org/D7087#131728, @elvisangelaccio wrote:
> In https://phabricator.kde.org/D7087#131719, @gregormi wrote:
>
> > > I see that you are adding also the "About KDE" action in the menu, but that \
action is already in the Help menu from the toolbar. What's the point of adding it \
twice? > >
> > Yes, the "About KDE" is already in the help menu of KInfoCenter. I thought \
about the situation when the "About System" module is started stand-alone (e.g. when \
you enter "About" in KRunner then "About System" is proposed). > >
> > In general, I would find it helpful if there was a menu item that opens \
KInfoCenter; but only if "About System" is shown stand-alone. I don't know how to \
determine if a system setting module is started stand-alone. >
>
> Oh I didn't even know that kinfocenter was a collection of kcm modules. I wonder \
if that should be implemented for all KCMs: currently the Help button in a \
stand-alone KCM just opens the kcm dockbook, maybe it could open the full-fledged \
Help menu?
1. In Spectacle the Help button on the left bottom corner is implemented as you \
described: as a menu button. +1 for having that in the KCMs, too. 2. In KInfoCenter \
the "Module Help" button seems to be broken. E.g. "Help" on the Memory KCM starts the \
Help Center at the correct location but the corresponding "Module Help" button in \
KInfoCenter opens a Help Center page titled with "Documentation not Found".
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, apol, mart, lukas
[Attachment #3 (unknown)]
<table><tr><td style="">gregormi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7087" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7087#131728" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7087#131728</a>, <a \
href="https://phabricator.kde.org/p/elvisangelaccio/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@elvisangelaccio</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8; color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D7087#131719" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D7087#131719</a>, <a \
href="https://phabricator.kde.org/p/gregormi/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@gregormi</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>I see that you are adding also the "About \
KDE" action in the menu, but that action is already in the Help menu from the \
toolbar. What's the point of adding it twice?</p></blockquote>
<p>Yes, the "About KDE" is already in the help menu of KInfoCenter. I \
thought about the situation when the "About System" module is started \
stand-alone (e.g. when you enter "About" in KRunner then "About \
System" is proposed).</p>
<p>In general, I would find it helpful if there was a menu item that opens \
KInfoCenter; but only if "About System" is shown stand-alone. I don't \
know how to determine if a system setting module is started stand-alone.</p></div> \
</blockquote>
<p>Oh I didn't even know that kinfocenter was a collection of kcm modules. I \
wonder if that should be implemented for all KCMs: currently the Help button in a \
stand-alone KCM just opens the kcm dockbook, maybe it could open the full-fledged \
Help menu?</p></div> </blockquote>
<ol class="remarkup-list">
<li class="remarkup-list-item">In Spectacle the Help button on the left bottom corner \
is implemented as you described: as a menu button. +1 for having that in the KCMs, \
too.</li> <li class="remarkup-list-item">In KInfoCenter the "Module Help" \
button seems to be broken. E.g. "Help" on the Memory KCM starts the Help \
Center at the correct location but the corresponding "Module Help" button \
in KInfoCenter opens a Help Center page titled with "Documentation not \
Found".</li> </ol></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087" \
rel="noreferrer">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>To: </strong>gregormi<br /><strong>Cc: </strong>sebas, \
elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, apol, mart, lukas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic