--===============2242579321718085379== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On July 31, 2017, 9:52 a.m., Sebastian Kügler wrote: > > Reviewboard isn't used for Plasma anymore. Would you mind putting this patch up on phabricator so it can be reviewed there? Sure, I will put this patch on phabricator. I guess, the file src/kde/workspace/kinfocenter/.reviewboardrc in the kinfocenter repository should be replaced by something that points to phabricator instead of reviewboard. - Gregor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130208/#review103513 ----------------------------------------------------------- On July 31, 2017, 7:44 a.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130208/ > ----------------------------------------------------------- > > (Updated July 31, 2017, 7:44 a.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: kinfocenter > > > Description > ------- > > Add a new menu with a "Copy to Clipboard" action to the About System module. See screenshot. The action can be used to conveniently copy information when reporting a bug etc. > > Example of how the copied text looks like: > > KDE Frameworks Version: 5.37.0 > Qt Version: 5.9.0 > Distro: openSUSE Tumbleweed 20170407 > Kernel: 4.10.8-1-default > OS Type: 64 bit > Processors: 4 × Intel® Core™ i3 CPU M 370 @ 2.40GHz > Memory: 7,7 GiB of RAM > > > Diffs > ----- > > Modules/about-distro/src/Module.h 55337b0e057fda97019291ba1dda1a5c330bb05a > Modules/about-distro/src/Module.cpp 1852376f96f1f6f4b1cbfdea446270000f84f401 > Modules/about-distro/src/Module.ui 7aff8c4b9162ee04240d0b77f3b1ec9757420322 > > Diff: https://git.reviewboard.kde.org/r/130208/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > About System with the new menu > https://git.reviewboard.kde.org/media/uploaded/files/2017/07/30/13bd0d7a-7a6a-4b48-90ba-4a6dffccd2ac__about-system-1.png > About system with the new menu opened > https://git.reviewboard.kde.org/media/uploaded/files/2017/07/30/9a79cbb6-0c50-4d4d-b24c-48e534aa9086__about-system-menu-open.png > > > Thanks, > > Gregor Mi > > --===============2242579321718085379== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130208/

On July 31st, 2017, 9:52 a.m. UTC, Sebastian Kügler wrote:

Reviewboard isn't used for Plasma anymore. Would you mind putting this patch up on phabricator so it can be reviewed there?
Sure, I will put this patch on phabricator. I guess, the file src/kde/workspace/kinfocenter/.reviewboardrc in the kinfocenter repository should be replaced by something that points to phabricator instead of reviewboard.

- Gregor


On July 31st, 2017, 7:44 a.m. UTC, Gregor Mi wrote:

Review request for Plasma and KDE Usability.
By Gregor Mi.

Updated July 31, 2017, 7:44 a.m.

Repository: kinfocenter

Description 

Add a new menu with a "Copy to Clipboard" action to the About System module. See screenshot. The action can be used to conveniently copy information when reporting a bug etc.


Example of how the copied text looks like:


KDE Frameworks Version: 5.37.0
Qt Version: 5.9.0
Distro: openSUSE Tumbleweed 20170407
Kernel: 4.10.8-1-default
OS Type: 64 bit
Processors: 4 × Intel® Core™ i3 CPU M 370 @ 2.40GHz
Memory: 7,7 GiB of RAM

Diffs

  • Modules/about-distro/src/Module.h (55337b0e057fda97019291ba1dda1a5c330bb05a)
  • Modules/about-distro/src/Module.cpp (1852376f96f1f6f4b1cbfdea446270000f84f401)
  • Modules/about-distro/src/Module.ui (7aff8c4b9162ee04240d0b77f3b1ec9757420322)

View Diff

File Attachments

  • About System with the new menu
  • About system with the new menu opened
    		•
    --===============2242579321718085379==--