[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D6974: Make unittest independent from the location of the executable.
From: David Faure <noreply () phabricator ! kde ! org>
Date: 2017-07-29 6:42:50
Message-ID: differential-rev-PHID-DREV-ybmr7cmkgxnslvandxrp-req () phabricator ! kde ! org
[Download RAW message or body]
dfaure created this revision.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
This fixes the check in the unittest when doing
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")
which I intend to do globally at some point.
Turns out it's comparing with its own executable location, so we
can use QCoreApplication to get it generically.
TEST PLAN
Verified to work with ctest and with "./testWaylandServerDisplay"
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6974
AFFECTED FILES
autotests/server/CMakeLists.txt
autotests/server/test_display.cpp
To: dfaure, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
[Attachment #3 (unknown)]
<table><tr><td style="">dfaure created this revision.<br />Restricted Application \
added subscribers: Frameworks, plasma-devel.<br />Restricted Application added \
projects: Plasma on Wayland, Frameworks. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6974" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
fixes the check in the unittest when doing<br /> set(CMAKE_RUNTIME_OUTPUT_DIRECTORY \
"${CMAKE_BINARY_DIR}/bin")<br /> which I intend to do globally at some \
point.</p>
<p>Turns out it's comparing with its own executable location, so we<br />
can use QCoreApplication to get it generically.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Verified to work with ctest and with \
"./testWaylandServerDisplay"</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6974" \
rel="noreferrer">https://phabricator.kde.org/D6974</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>autotests/server/CMakeLists.txt<br /> \
autotests/server/test_display.cpp</div></div></div><br /><div><strong>To: \
</strong>dfaure, graesslin<br /><strong>Cc: </strong>plasma-devel, Frameworks, leezu, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, \
apol, mart, hein, lukas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic