[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 130205: View Styles
From: Andreas Kainz <kainz.a () gmail ! com>
Date: 2017-07-28 20:35:35
Message-ID: 20170728203535.29788.33024 () mimi ! kde ! org
[Download RAW message or body]
--===============5947244015625241192==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Juli 28, 2017, 9:14 vorm., Sebastian Kügler wrote:
> > Why?
> >
> > The mode chooser is hidden well enough that it doesn't produce visual noise and \
> > not a lot of extra burden on the user (since there's UI for switching anyway, 2 \
> > or 3 options doesn't make it a lot lighter). Moreover, the tree view is something \
> > users seem to actually like and use, and the code for it has aged well and \
> > doesn't require maintenance, so it's not a lot of technical debt to carry around. \
> >
> > This patch doesn't remove the actual code, it just removes the entry which \
> > essentially leaves dead code around, so the patch is technically insufficient.
this patch didn't remove anything it's only change in System Settings -> Configure \
dialog -> View Style the list to
Tree View
Icon View
Sidebar View
Instead of
Classic Tree View
Icon View
Sidebar View
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130205/#review103488
-----------------------------------------------------------
On Juli 26, 2017, 9:54 nachm., Andreas Kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130205/
> -----------------------------------------------------------
>
> (Updated Juli 26, 2017, 9:54 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: systemsettings
>
>
> Description
> -------
>
> as system settings has now 3 different views the classic should be removed from the \
> tree view in configure dialogue.
>
> Diffs
> -----
>
> classic/settings-classic-view.desktop 57cd2a3
>
> Diff: https://git.reviewboard.kde.org/r/130205/diff/
>
>
> Testing
> -------
>
> none.
>
>
> Thanks,
>
> Andreas Kainz
>
>
--===============5947244015625241192==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130205/">https://git.reviewboard.kde.org/r/130205/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Juli 28th, 2017, 9:14 vorm. UTC, <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Why?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The mode chooser is \
hidden well enough that it doesn't produce visual noise and not a lot of extra burden \
on the user (since there's UI for switching anyway, 2 or 3 options doesn't make it a \
lot lighter). Moreover, the tree view is something users seem to actually like and \
use, and the code for it has aged well and doesn't require maintenance, so it's not a \
lot of technical debt to carry around.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch doesn't \
remove the actual code, it just removes the entry which essentially leaves dead code \
around, so the patch is technically insufficient.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
patch didn't remove anything it's only change in System Settings -> Configure \
dialog -> View Style the list to</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Tree View Icon View
Sidebar View</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Instead of Classic Tree View
Icon View
Sidebar View</p></pre>
<br />
<p>- Andreas</p>
<br />
<p>On Juli 26th, 2017, 9:54 nachm. UTC, Andreas Kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andreas Kainz.</div>
<p style="color: grey;"><i>Updated Juli 26, 2017, 9:54 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
systemsettings
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">as system settings has now 3 different views the \
classic should be removed from the tree view in configure dialogue.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">none.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>classic/settings-classic-view.desktop <span style="color: \
grey">(57cd2a3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130205/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5947244015625241192==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic