[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6956: Stop unnecessarily killing IBus when applying keyboard layouts config
From:       Evgeny Brazgin <noreply () phabricator ! kde ! org>
Date:       2017-07-28 6:34:03
Message-ID: 20170728063400.76562.E7ED03785913341C () phabricator ! kde ! org
[Download RAW message or body]

xapienz added a comment.


  I think it would also be good to remove the line `static bool preInitialize();` in \
kcms/keyboard/xkb_helper.h, because it will be unused.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6956

To: achauvel
Cc: xapienz, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">xapienz added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6956" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I think it would also be good to remove \
the line <tt style="background: #ebebeb; font-size: 13px;">static bool \
preInitialize();</tt> in kcms/keyboard/xkb_helper.h, because it will be \
unused.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6956" \
rel="noreferrer">https://phabricator.kde.org/D6956</a></div></div><br \
/><div><strong>To: </strong>achauvel<br /><strong>Cc: </strong>xapienz, plasma-devel, \
Plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]