[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6571: Delete all Wayland connections by plugins prior to own Wayland connection
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-07-27 17:37:31
Message-ID: 20170727173726.125211.2686FC773EDDA72C () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in wayland_server.cpp:99
> Yeah that should work as well. Though of course the documentation of \
> ConnectionThread says it's not emitted if created from application, but we can fix \
> that ;-) 
> It might mean we leak a few resources, but as we are shutting down anyway...

RE: https://phabricator.kde.org/D6727

> That would basically allow us to abandon https://phabricator.kde.org/D6571 and \
> would also solve the issues we see with the kwayland-integration plugin which can \
> crash applications on exit.

I'd like to see this patch merged (but with the emit connectionDied) 
It might work without, but it still leaves a window where someone calling \
foo->destroy() would crash.

REPOSITORY
  R108 KWin

BRANCH
  connection-cleanup

REVISION DETAIL
  https://phabricator.kde.org/D6571

To: graesslin, #kwin, #plasma, mart
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6571" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6571#inline-27739" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">graesslin</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">wayland_server.cpp:99</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Yeah that should work as well. \
Though of course the documentation of ConnectionThread says it&#039;s not emitted if \
created from application, but we can fix that ;-)</p>

<p style="padding: 0; margin: 8px;">It might mean we leak a few resources, but as we \
are shutting down anyway...</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">RE: <a \
href="https://phabricator.kde.org/D6727" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6727</a></p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p \
style="padding: 0; margin: 8px;">That would basically allow us to abandon <a \
href="https://phabricator.kde.org/D6571" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6571</a> and would \
also solve the issues we see with the kwayland-integration plugin which can crash \
applications on exit.</p></blockquote>

<p style="padding: 0; margin: 8px;">I&#039;d like to see this patch merged (but with \
the emit connectionDied) <br /> It might work without, but it still leaves a window \
where someone calling foo-&gt;destroy() would \
crash.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>connection-cleanup</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6571" \
rel="noreferrer">https://phabricator.kde.org/D6571</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, mart<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]