[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6718: Fix occasional abort in the krunner plugin
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-07-27 15:01:49
Message-ID: 20170727130232.78434.6176ABD860672A7F () phabricator ! kde ! org
[Download RAW message or body]

broulik added a comment.


  @davidedmundson Should we go with this now?

INLINE COMMENTS

> tabsrunner.cpp:103
> 
> -        if (reply.type() != QDBusMessage::ReplyMessage) {
> +        if (reply.type() != QDBusMessage::ReplyMessage || \
> reply.arguments().length() < 1) { continue;

Perhaps even check `!= 1` - it shouldn't have more than one argument either.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D6718

To: fvogt, #plasma, broulik, davidedmundson
Cc: heikobecker, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6718" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p><a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> Should we go \
with this now?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6718#inline-28429" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">tabsrunner.cpp:103</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">if</span> \
<span class="p">(</span><span class="n">reply</span><span class="p">.</span><span \
class="n">type</span><span class="p">()</span> <span style="color: #aa2211">!=</span> \
<span class="n">QDBusMessage</span><span style="color: #aa2211">::</span><span \
class="n">ReplyMessage</span><span class="p">)</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">reply</span><span class="p">.</span><span class="n">type</span><span \
class="p">()</span> <span style="color: #aa2211">!=</span> <span \
class="n">QDBusMessage</span><span style="color: #aa2211">::</span><span \
class="n">ReplyMessage<span class="bright"></span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">||</span></span><span \
class="bright"> </span><span class="n"><span class="bright">reply</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">arguments</span></span><span class="bright"></span><span \
class="p"><span class="bright">().</span></span><span class="bright"></span><span \
class="n"><span class="bright">length</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">&lt;</span></span><span class="bright"> \
</span><span style="color: #601200"><span class="bright">1</span></span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; ">            <span style="color: #aa4000">continue</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Perhaps even check <tt style="background: #ebebeb; font-size: 13px;">!= 1</tt> \
- it shouldn&#039;t have more than one argument \
either.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser \
Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6718" \
rel="noreferrer">https://phabricator.kde.org/D6718</a></div></div><br \
/><div><strong>To: </strong>fvogt, Plasma, broulik, davidedmundson<br /><strong>Cc: \
</strong>heikobecker, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]