[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6933: [Component Chooser] Update http(s) scheme handler when changing default browser
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-07-26 14:53:36
Message-ID: differential-rev-PHID-DREV-w2qb6fmwwaxeumn4x7hc-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 332817

TEST PLAN
  Similar to how it's done with mailto in the Email client chooser.
  Although I do `KBuildSycocaProgressDialog::rebuildKSycoca` I still need to run \
`kbuildsycoca5` before `xdg-mime` actually reflects the change.  
  Didn't actually test any of the apps mentioned but `xdg-mime query default \
x-scheme-handler/http` returned the correct handler after I changed the setting. If \
no service is found (custom commandline), the entry is removed from config and the \
inherited one from `/usr/share/applications` (Firefox in my case) will be used.  
  Should we also update the handler for `text/html` mime type?
  
  (This obviously doesn't help when the user installed the browser that did not \
register itself as scheme handler and then does not touch this setting here...)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6933

AFFECTED FILES
  kcms/componentchooser/componentchooserbrowser.cpp

To: broulik, #plasma, dfaure
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6933" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>BUG: \
332817</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Similar to how \
it&#039;s done with mailto in the Email client chooser.<br /> Although I do <tt \
style="background: #ebebeb; font-size: \
13px;">KBuildSycocaProgressDialog::rebuildKSycoca</tt> I still need to run <tt \
style="background: #ebebeb; font-size: 13px;">kbuildsycoca5</tt> before <tt \
style="background: #ebebeb; font-size: 13px;">xdg-mime</tt> actually reflects the \
change.</p>

<p>Didn&#039;t actually test any of the apps mentioned but <tt style="background: \
#ebebeb; font-size: 13px;">xdg-mime query default x-scheme-handler/http</tt> returned \
the correct handler after I changed the setting. If no service is found (custom \
commandline), the entry is removed from config and the inherited one from <tt \
style="background: #ebebeb; font-size: 13px;">/usr/share/applications</tt> (Firefox \
in my case) will be used.</p>

<p>Should we also update the handler for <tt style="background: #ebebeb; font-size: \
13px;">text/html</tt> mime type?</p>

<p>(This obviously doesn&#039;t help when the user installed the browser that did not \
register itself as scheme handler and then does not touch this setting \
here...)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6933" \
rel="noreferrer">https://phabricator.kde.org/D6933</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kcms/componentchooser/componentchooserbrowser.cpp</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, dfaure<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]