[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6791: Drop the Workspace::slotSwitchWindowFoo methods
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-07-20 5:13:11
Message-ID: differential-rev-PHID-DREV-llolutzq4655h7bqs3q3-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  They were only delegating into switchWindow(Direction), so let's do the
  same through std::bind in kwinbindings and delegate to it directly in
  scripting's WorkspaceWrapper.

TEST PLAN
  Not yet, want to add test case for Workspace::switchWindow

BRANCH
  no-slot-switch-window

REVISION DETAIL
  https://phabricator.kde.org/D6791

AFFECTED FILES
  kwinbindings.cpp
  scripting/workspace_wrapper.cpp
  useractions.cpp
  workspace.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin created this revision.<br />Restricted Application \
added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6791" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>They \
were only delegating into switchWindow(Direction), so let&#039;s do the<br /> same \
through std::bind in kwinbindings and delegate to it directly in<br /> \
scripting&#039;s WorkspaceWrapper.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Not yet, want to add test case for \
Workspace::switchWindow</p></div></div><br \
/><div><strong>BRANCH</strong><div><div>no-slot-switch-window</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6791" \
rel="noreferrer">https://phabricator.kde.org/D6791</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kwinbindings.cpp<br /> \
scripting/workspace_wrapper.cpp<br /> useractions.cpp<br />
workspace.h</div></div></div><br /><div><strong>To: </strong>graesslin, KWin, \
Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]