[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6727: Destroy all kwayland objects created by registry when it is destroyed
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-07-15 20:01:04
Message-ID: differential-rev-PHID-DREV-srfer7ws2x4vywubqpwy-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.

REVISION SUMMARY
  Currently one has to connect every object manually to connectionDied,
  which is something we can do for them.
  
  If the user also has a connection, the second will just no-op.
  
  Will add some awesome docs / unit tests if you're into the idea.

TEST PLAN
  Commit 2:
  Emit connectionDied if the QPA owns the connection and is destroyed.
  
  We have a few objects that linger longer than the qApp. 
  I've got a crash in plasmashell, and I've had a crash with breeze wrapping
  a dangly menu in konversation. This should fix those.

REPOSITORY
  R127 KWayland

BRANCH
  davidedmundson/xdgv6

REVISION DETAIL
  https://phabricator.kde.org/D6727

AFFECTED FILES
  src/client/connection_thread.cpp
  src/client/output.cpp
  src/client/output.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/registry.cpp
  src/client/registry.h

To: davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson created this revision.<br />Restricted \
Application added subscribers: Frameworks, plasma-devel.<br />Restricted Application \
added projects: Plasma on Wayland, Frameworks. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6727" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Currently one has to connect every object manually to \
connectionDied,<br /> which is something we can do for them.</p>

<p>If the user also has a connection, the second will just no-op.</p>

<p>Will add some awesome docs / unit tests if you&#039;re into the \
idea.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Commit 2:<br /> \
Emit connectionDied if the QPA owns the connection and is destroyed.</p>

<p>We have a few objects that linger longer than the qApp. <br />
I&#039;ve got a crash in plasmashell, and I&#039;ve had a crash with breeze \
wrapping<br /> a dangly menu in konversation. This should fix \
those.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 \
KWayland</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>davidedmundson/xdgv6</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6727" \
rel="noreferrer">https://phabricator.kde.org/D6727</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/client/connection_thread.cpp<br \
/> src/client/output.cpp<br />
src/client/output.h<br />
src/client/outputdevice.cpp<br />
src/client/outputdevice.h<br />
src/client/registry.cpp<br />
src/client/registry.h</div></div></div><br /><div><strong>To: \
</strong>davidedmundson<br /><strong>Cc: </strong>plasma-devel, Frameworks, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, \
mart, hein, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]