[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6571: Delete all Wayland connections by plugins prior to own Wayland connection
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-07-15 19:50:20
Message-ID: 20170715195020.51902.64DBCC36FB10B0F7 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> wayland_server.cpp:93
> if (m_internalConnection.client) {
> +        // delete all connections hold by plugins like e.g. widget style
> +        const auto connections = \
> KWayland::Client::ConnectionThread::connections();

s/hold/held.

> wayland_server.cpp:99
> +            }
> +            delete c;
> +        }

Alternative.

Instead of deleting qobjects

emit c->connectionDied();

Clients then call destroy() on whatever objects.
They can then delete the QObjects whenever they were going to.

REPOSITORY
  R108 KWin

BRANCH
  connection-cleanup

REVISION DETAIL
  https://phabricator.kde.org/D6571

To: graesslin, #kwin, #plasma, mart
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6571" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6571#inline-27246" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">wayland_server.cpp:93</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span \
class="p">(</span><span class="n">m_internalConnection</span><span \
class="p">.</span><span class="n">client</span><span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span style="color: #74777d">// delete all \
connections hold by plugins like e.g. widget style</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span \
style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span \
class="n">connections</span> <span style="color: #aa2211">=</span> <span \
class="n">KWayland</span><span style="color: #aa2211">::</span><span \
class="n">Client</span><span style="color: #aa2211">::</span><span \
class="n">ConnectionThread</span><span style="color: #aa2211">::</span><span \
class="n">connections</span><span class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">s/hold/held.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D6571#inline-27738" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">wayland_server.cpp:99</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span \
class="p">}</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">            <span style="color: #aa4000">delete</span> \
<span class="n">c</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Alternative.</p>

<p style="padding: 0; margin: 8px;">Instead of deleting qobjects</p>

<p style="padding: 0; margin: 8px;">emit c-&gt;connectionDied();</p>

<p style="padding: 0; margin: 8px;">Clients then call destroy() on whatever \
objects.<br /> They can then delete the QObjects whenever they were going \
to.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>connection-cleanup</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6571" \
rel="noreferrer">https://phabricator.kde.org/D6571</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, mart<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]