[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6673: [Notifications] Manually remove remote images
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-07-14 9:33:38
Message-ID: 20170714093338.115003.FA18CD3102C6D460 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  Addressing the text first:
  
  > The network access manager factory we install is ineffective as Plasma uses a \
shared engine nowadays and whenever a new QmlObject shared engine is created, its \
setupBindings will re-install the KIO access factory.  
  There used to be a .desktop flag for that..
  
  > (Btw I noticed that setupBindings is called >100 times on Plasma startup, setting \
up the very same QML engine over and over again, including creating a KIO NAM \
factory, KLocalizedContext and KIcon image provider)  
  calling setupBindings() is needed as we install the ki18n on the context (which is \
different), but you're right that the stuff with the engine could indeed be done \
once.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6673

To: broulik, #plasma, fvogt
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6673" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Addressing the text first:</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The \
network access manager factory we install is ineffective as Plasma uses a shared \
engine nowadays and whenever a new QmlObject shared engine is created, its \
setupBindings will re-install the KIO access factory.</p></blockquote>

<p>There used to be a .desktop flag for that..</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>(Btw \
I noticed that setupBindings is called &gt;100 times on Plasma startup, setting up \
the very same QML engine over and over again, including creating a KIO NAM factory, \
KLocalizedContext and KIcon image provider)</p></blockquote>

<p>calling setupBindings() is needed as we install the ki18n on the context (which is \
different), but you&#039;re right that the stuff with the engine could indeed be done \
once.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6673" \
rel="noreferrer">https://phabricator.kde.org/D6673</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, fvogt<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]