[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6673: [Notifications] Manually remove remote images
From:       Fabian Vogt <noreply () phabricator ! kde ! org>
Date:       2017-07-14 8:40:40
Message-ID: 20170714084035.60221.97BE9FA4992EEF74 () phabricator ! kde ! org
[Download RAW message or body]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> textsanitizer.cpp:45
> +    for (int i = 0; i < newDocument->blockCount(); ++i) {
> +        QTextBlock block = newDocument->findBlock(i);
> +

(Already noted on IRC)

This doesn't do what it's intended to do, `findBlockByNumber` is needed here.
Otherwise it only goes through the first few blocks and leaves the rest as-is:

> notify-send "a" "<span>a</span><div>a</div><div>b</div><img \
> src='http://localhost'/>"

results in

> file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/NotificationItem.qml:268:17: \
> QML TextEdit: localhost: Connection refused

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6673

To: broulik, #plasma, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">fvogt requested changes to this revision.<br />fvogt added \
inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6673" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D6673#inline-27627" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">textsanitizer.cpp:45</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">int</span> \
<span class="n">i</span> <span style="color: #aa2211">=</span> <span style="color: \
#601200">0</span><span class="p">;</span> <span class="n">i</span> <span \
style="color: #aa2211">&lt;</span> <span class="n">newDocument</span><span \
style="color: #aa2211">-&gt;</span><span class="n">blockCount</span><span \
class="p">();</span> <span style="color: #aa2211">++</span><span \
class="n">i</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="n">QTextBlock</span> <span class="n">block</span> <span style="color: \
#aa2211">=</span> <span class="n">newDocument</span><span style="color: \
#aa2211">-&gt;</span><span class="n">findBlock</span><span class="p">(</span><span \
class="n">i</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">(Already noted on IRC)</p>

<p style="padding: 0; margin: 8px;">This doesn&#039;t do what it&#039;s intended to \
do, <tt style="background: #ebebeb; font-size: 13px;">findBlockByNumber</tt> is \
needed here.<br /> Otherwise it only goes through the first few blocks and leaves the \
rest as-is:</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p \
style="padding: 0; margin: 8px;">notify-send &quot;a&quot; \
&quot;&lt;span&gt;a&lt;/span&gt;&lt;div&gt;a&lt;/div&gt;&lt;div&gt;b&lt;/div&gt;&lt;img \
src=&#039;http://localhost&#039;/&gt;&quot;</p></blockquote>

<p style="padding: 0; margin: 8px;">results in</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p \
style="padding: 0; margin: \
8px;">file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/NotificationItem.qml:268:17: \
QML TextEdit: localhost: Connection \
refused</p></blockquote></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6673" \
rel="noreferrer">https://phabricator.kde.org/D6673</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, fvogt<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]