[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6455: position the shellsurface immediately
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-07-11 15:34:34
Message-ID: 20170711153431.12441.E079B18F8DCED510 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.


  What I don't like about it is that KWin will get and react on two events with one \
having invalid coordinates. We get an event for the change of x and at that point y \
might be invalid. KWin will position the window there and that can result in mess \
(e.g. all windows get resized because the maximize area changes).  
  Otherwise it's similar to what KWin does for it's own windows, though KWin doesn't \
create panels which is a huge difference.  
  So I would prefer a solution which only creates one setPosition event.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6455

To: mart, #plasma, graesslin
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6455" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>What I don&#039;t like about it is that \
KWin will get and react on two events with one having invalid coordinates. We get an \
event for the change of x and at that point y might be invalid. KWin will position \
the window there and that can result in mess (e.g. all windows get resized because \
the maximize area changes).</p>

<p>Otherwise it&#039;s similar to what KWin does for it&#039;s own windows, though \
KWin doesn&#039;t create panels which is a huge difference.</p>

<p>So I would prefer a solution which only creates one setPosition \
event.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6455" \
rel="noreferrer">https://phabricator.kde.org/D6455</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, graesslin<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]