[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6456: [lookandfeel/lockscreen] Fix state handling when clicking the keyboard's own hide button
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-06-30 18:08:27
Message-ID: differential-rev-PHID-DREV-hoai5c623gzrlqo7dhij-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When clicking the hide button provided by the virtual keyboard, the
  keyboard hides, but the state is not updated. This means the animation
  for hide is not triggered and even more important the next call to
  showHide sets a wrong state. The state assumes it is in visible, when
  clicking it goes to hidden. So the virtual keyboard is not getting shown
  when clicking the show virtual keyboard button.
  
  To address this problem a change handler for keyboardActive is added
  which ensures the state is correct whenever the keyboardActive value
  changes.
  
  BUG: 381833
  FIXED-IN: 5.10.4

REPOSITORY
  R120 Plasma Workspace

BRANCH
  ensure-state-keyboard-active-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6456

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: graesslin, #plasma, sitter
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin created this revision.<br />Restricted Application \
added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6456" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>When \
clicking the hide button provided by the virtual keyboard, the<br /> keyboard hides, \
but the state is not updated. This means the animation<br /> for hide is not \
triggered and even more important the next call to<br /> showHide sets a wrong state. \
The state assumes it is in visible, when<br /> clicking it goes to hidden. So the \
virtual keyboard is not getting shown<br /> when clicking the show virtual keyboard \
button.</p>

<p>To address this problem a change handler for keyboardActive is added<br />
which ensures the state is correct whenever the keyboardActive value<br />
changes.</p>

<p>BUG: 381833<br />
FIXED-IN: 5.10.4</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 \
Plasma Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>ensure-state-keyboard-active-5.10</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6456" \
rel="noreferrer">https://phabricator.kde.org/D6456</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>lookandfeel/contents/lockscreen/LockScreenUi.qml</div></div></div><br \
/><div><strong>To: </strong>graesslin, Plasma, sitter<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]