From kde-panel-devel  Thu Jun 29 13:57:11 2017
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: Thu, 29 Jun 2017 13:57:11 +0000
To: kde-panel-devel
Subject: D6386: [Digital Clock] Allow speaking out loud current time
Message-Id: <20170629135708.31817.A8FA736FCC1FDAA7 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=149874464228679
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--dfa3137acfc14ed1ace167d4178fc5bd"

--dfa3137acfc14ed1ace167d4178fc5bd
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in main.xml:65
> It does not have to be. It also says "every n *minutes*"

It does. you take the modulus. If you have it every 19 minutes you'd announce on:

21:57, 22:00,  22:19

that's not every 19 minutes. You jump about every hour.

REVISION DETAIL
  https://phabricator.kde.org/D6386

To: broulik, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

--dfa3137acfc14ed1ace167d4178fc5bd
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">davidedmundson added inline comments.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D6386" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style=3D"=
margin: 6px 0 12px 0;"><div style=3D"border: 1px solid #C7CCD9; border-radi=
us: 3px;"><div style=3D"padding: 0; background: #F7F7F7; border-color: #e3e=
4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style=
=3D"color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden=
;"><a style=3D"float: right; text-decoration: none;" href=3D"https://phabri=
cator.kde.org/D6386#inline-26565" rel=3D"noreferrer">View Inline</a><span s=
tyle=3D"color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span s=
tyle=3D"color: #4b4d51; font-weight: bold;">main.xml:65</span></div>
<div style=3D"margin: 8px 0; padding: 0 12px; color: #74777D;"><p style=3D"=
padding: 0; margin: 8px;">It does not have to be. It also says &quot;every =
n *minutes*&quot;</p></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">It does. you take the modulus. If you have it every 19 minutes yo=
u&#039;d announce on:</p>

<p style=3D"padding: 0; margin: 8px;">21:57, 22:00,  22:19</p>

<p style=3D"padding: 0; margin: 8px;">that&#039;s not every 19 minutes. You=
 jump about every hour.</p></div></div></div></div></div><br /><div><strong=
>REVISION DETAIL</strong><div><a href=3D"https://phabricator.kde.org/D6386"=
 rel=3D"noreferrer">https://phabricator.kde.org/D6386</a></div></div><br />=
<div><strong>To: </strong>broulik, Plasma, VDG<br /><strong>Cc: </strong>da=
videdmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je=
nsreuterberg, abetts, sebas, apol, mart, lukas<br /></div>
--dfa3137acfc14ed1ace167d4178fc5bd--