[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6424: [Scripting] Throw a error from the Containment when the widget is not found
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-06-28 20:44:13
Message-ID: 20170628204407.87299.93FF281C0D3ED356 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  In principle fine.

INLINE COMMENTS

> containment.cpp:217
> return env->wrap(applet);
> }
> }

what about this one?

> containment.cpp:230
> +
> +        return context->throwError(i18n("Could not find widget!"));
> } else if (Widget *widget = qobject_cast<Widget*>(v.toQObject())) {

s/find/create

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6424

To: garg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added a comment.<br />This revision now requires changes to proceed. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6424" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>In principle fine.</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D6424#inline-26508" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">containment.cpp:217</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">                <span style="color: #aa4000">return</span> <span \
class="n">env</span><span style="color: #aa2211">-&gt;</span><span \
class="n">wrap</span><span class="p">(</span><span class="n">applet</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; ">            \
<span class="p">}</span> </div><div style="padding: 0 8px; margin: 0 4px; ">        \
<span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">what \
about this one?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D6424#inline-26507" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">containment.cpp:230</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">return</span> <span class="n">context</span><span style="color: \
#aa2211">-&gt;</span><span class="n">throwError</span><span class="p">(</span><span \
class="n">i18n</span><span class="p">(</span><span style="color: #766510">&quot;Could \
not find widget!&quot;</span><span class="p">));</span> </div><div style="padding: 0 \
8px; margin: 0 4px; ">    <span class="p">}</span> <span style="color: \
#aa4000">else</span> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span class="n">Widget</span> <span style="color: \
#aa2211">*</span><span class="n">widget</span> <span style="color: #aa2211">=</span> \
<span class="n">qobject_cast</span><span style="color: #aa2211">&lt;</span><span \
class="n">Widget</span><span style="color: #aa2211">*&gt;</span><span \
class="p">(</span><span class="n">v</span><span class="p">.</span><span \
class="n">toQObject</span><span class="p">()))</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">s/find/create</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6424" \
rel="noreferrer">https://phabricator.kde.org/D6424</a></div></div><br \
/><div><strong>To: </strong>garg, Plasma, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]