[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6418: [XDGV6] manage every ping sent
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-28 15:02:25
Message-ID: differential-rev-PHID-DREV-v4v7bri755f525a7f6f2-req () phabricator ! kde ! org
[Download RAW message or body]

mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  if more ping arrives before a pong, store each of its
  serial and manage them one by one
  
  a new signal, pingTimeout emitted until explicitly stopped

TEST PLAN
  tests still pass, kwin modified to use it on window close
  and window focus gain works correctly.
  What is not tested: apps not answering to pings
  as usually the connection thread will still be
  running, so something to actually query the gui
  thread will be needed

REPOSITORY
  R127 KWayland

BRANCH
  mart/xdgv6ping

REVISION DETAIL
  https://phabricator.kde.org/D6418

AFFECTED FILES
  autotests/client/test_xdg_shell.cpp
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_v5_interface.cpp
  src/server/xdgshell_v6_interface.cpp

To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart created this revision.<br />Restricted Application added \
projects: Plasma on Wayland, Frameworks.<br />Restricted Application added \
subscribers: Frameworks, plasma-devel. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6418" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>if more \
ping arrives before a pong, store each of its<br /> serial and manage them one by \
one</p>

<p>a new signal, pingTimeout emitted until explicitly stopped</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>tests still pass, kwin modified to use it on \
window close<br /> and window focus gain works correctly.<br />
What is not tested: apps not answering to pings<br />
as usually the connection thread will still be<br />
running, so something to actually query the gui<br />
thread will be needed</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>mart/xdgv6ping</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6418" \
rel="noreferrer">https://phabricator.kde.org/D6418</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>autotests/client/test_xdg_shell.cpp<br /> \
src/server/xdgshell_interface.cpp<br /> src/server/xdgshell_interface.h<br />
src/server/xdgshell_interface_p.h<br />
src/server/xdgshell_v5_interface.cpp<br />
src/server/xdgshell_v6_interface.cpp</div></div></div><br /><div><strong>To: \
</strong>mart, Plasma, davidedmundson, graesslin<br /><strong>Cc: \
</strong>plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]