From kde-panel-devel  Tue Jun 27 19:10:58 2017
From: =?utf-8?q?Martin_Fl=C3=B6ser?= <noreply () phabricator ! kde ! org>
Date: Tue, 27 Jun 2017 19:10:58 +0000
To: kde-panel-devel
Subject: D6411: [platforms/x11] Use a GlxContextAttributeBuilder
Message-Id: <differential-rev-PHID-DREV-g6meorhacojc27bzfvim-req () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=149859067510593
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--8917525edc154b9aa9e99dfb389b911a"

--8917525edc154b9aa9e99dfb389b911a
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Based on the work of https://phabricator.kde.org/R108:3f4995fb9b4fd753a304ea65020bbafdd174936b this change
  introduces a GlxContextAttributeBuilder to make the requesting of context
  attributes cleaner, more verbose and less error prone copy and paste.

TEST PLAN
  Switched between Core and legacy and verified the output;
  extended auto test

BRANCH
  glx-context-attribute-builder

REVISION DETAIL
  https://phabricator.kde.org/D6411

AFFECTED FILES
  abstract_opengl_context_attribute_builder.h
  autotests/CMakeLists.txt
  autotests/opengl_context_attribute_builder_test.cpp
  plugins/platforms/x11/standalone/CMakeLists.txt
  plugins/platforms/x11/standalone/glx_context_attribute_builder.cpp
  plugins/platforms/x11/standalone/glx_context_attribute_builder.h
  plugins/platforms/x11/standalone/glxbackend.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

--8917525edc154b9aa9e99dfb389b911a
Content-Transfer-Encoding: 7bit
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style="">graesslin created this revision.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6411" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Based on the work of <a href="https://phabricator.kde.org/R108:3f4995fb9b4fd753a304ea65020bbafdd174936b" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">3f4995fb9b4fd753a304ea65020bbafdd174936b</a> this change<br />
introduces a GlxContextAttributeBuilder to make the requesting of context<br />
attributes cleaner, more verbose and less error prone copy and paste.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Switched between Core and legacy and verified the output;<br />
extended auto test</p></div></div><br /><div><strong>BRANCH</strong><div><div>glx-context-attribute-builder</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6411" rel="noreferrer">https://phabricator.kde.org/D6411</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>abstract_opengl_context_attribute_builder.h<br />
autotests/CMakeLists.txt<br />
autotests/opengl_context_attribute_builder_test.cpp<br />
plugins/platforms/x11/standalone/CMakeLists.txt<br />
plugins/platforms/x11/standalone/glx_context_attribute_builder.cpp<br />
plugins/platforms/x11/standalone/glx_context_attribute_builder.h<br />
plugins/platforms/x11/standalone/glxbackend.cpp</div></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>
--8917525edc154b9aa9e99dfb389b911a--