[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6403: get rid of manual window flags setting on controller
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-27 8:46:57
Message-ID: differential-rev-PHID-DREV-o2w6zi2zjugposo3pe43-req () phabricator ! kde ! org
[Download RAW message or body]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  with Qt 5.9, the panel controller can't get focus, so
  it can't be dismissed by clicking anywhere, (couldn't
  figure out what was the commit that caused the regression)
  removing the manual setting of flags seems to fix it,
  while the behavior seems unaltered with Qt 5.7 and 5.8

TEST PLAN
  tested on machines with Qt 5.7, 5.8 and 5.9 installed

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6403

AFFECTED FILES
  shell/panelconfigview.cpp

To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart created this revision.<br />Restricted Application added \
a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6403" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>with Qt \
5.9, the panel controller can&#039;t get focus, so<br /> it can&#039;t be dismissed \
by clicking anywhere, (couldn&#039;t<br /> figure out what was the commit that caused \
the regression)<br /> removing the manual setting of flags seems to fix it,<br />
while the behavior seems unaltered with Qt 5.7 and 5.8</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>tested on machines with Qt 5.7, 5.8 and 5.9 \
installed</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6403" \
rel="noreferrer">https://phabricator.kde.org/D6403</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>shell/panelconfigview.cpp</div></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]